Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M1 natives support #111

Closed
wants to merge 9 commits into from
Closed

M1 natives support #111

wants to merge 9 commits into from

Conversation

Tom-Ski
Copy link

@Tom-Ski Tom-Ski commented Feb 11, 2022

  • Upgrades gdx-jnigen to latest release version.
  • Changes the library loader to check for 64bit and arm to pick the right native path.
  • Added the new binary. Let me know if you want that removed, or generated yourself/GHA.

Tested this with local maven publishing, GHA untested.

@SpaiR
Copy link
Owner

SpaiR commented Feb 11, 2022

Hi! Thank you for your contribution. Changes look solid. Yet there is a problem that GitHub actions infrastructure doesn't support ARM builds of any kind. So for now I can't accept changes like yours. Release pipeline is fully automated and should stay like that. Manual release with compiling of binaries on a local machine is a total routine which I want to avoid.

@SpaiR SpaiR closed this Feb 11, 2022
@Tom-Ski
Copy link
Author

Tom-Ski commented Feb 11, 2022

@SpaiR it is possible to build m1 on mac. My latest changes should add the fixes for these issues in previous builds. We are using this over at https://github.com/libgdx/libgdx, and other repos for extensions to publish our m1 support.

@SpaiR
Copy link
Owner

SpaiR commented Feb 11, 2022

https://github.com/SpaiR/imgui-java/runs/5160749091?check_suite_focus=true#step:9:2409
Here is the output of the compiling job from your PR. It is said pretty straightforward that it's unsupported. 😕

You're probably confusing two different things: ability to create configs for ARM builds and ability to actually build them. The first one depends on a generation library (that is what gdx-jnigen can do). The second one depends on a build machine. Unfortunately, I don't know any magical way to create ARM builds on an AMD arch.

@Tom-Ski
Copy link
Author

Tom-Ski commented Feb 11, 2022

Here are the changes running at my fork, successfully compiling for arm64 arch https://github.com/Tom-Ski/imgui-java/runs/5161042680?check_suite_focus=true

@SpaiR
Copy link
Owner

SpaiR commented Feb 11, 2022

I see. Well, then there is a magical way... 😅 Next time please point links to workarounds like that at the first place. That will help to avoid any confusion from the beginning.
You still need to fix a freetype build though. 😏

@SpaiR SpaiR reopened this Feb 11, 2022
@Tom-Ski Tom-Ski closed this Feb 11, 2022
@Tom-Ski
Copy link
Author

Tom-Ski commented Feb 11, 2022

I'll reopen this when freetype is compiling and linking correctly to avoid the emails/notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants